[1269] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

krb5b4pl3: kadmin/v4server/kadm_funcs.c: swapped arguments in strncpy() calls

daemon@ATHENA.MIT.EDU (Jonathan I. Kamens)
Fri Mar 24 12:37:11 1995

From: "Jonathan I. Kamens" <jik@cam.ov.com>
Date: Fri, 24 Mar 1995 12:40:22 -0500
To: krb5-bugs@MIT.EDU

Two problems in kadm/v4server/kadm_funcs.c, one minor, one major:

1) The argument to ctime should be cast to const time_t *, to
eliminate compiler warnings.

2) The string arguments in two calls to strncpy were in the wrong
order.

Here's a patch:

--- kadm_funcs.c	1995/03/24 17:39:43	1.1
+++ kadm_funcs.c	1995/03/24 17:37:41
@@ -58,10 +58,10 @@
   if (retval)
     return retval;
   princ->exp_date = entry.expiration;
-  strncpy(ctime(&entry.expiration), princ->exp_date_txt,
+  strncpy(princ->exp_date_txt, ctime((const time_t *)&entry.expiration),
 	  DATE_SZ);
   princ->mod_date = entry.mod_date;
-  strncpy(ctime(&entry.mod_date), princ->mod_date_txt,
+  strncpy(princ->mod_date_txt, ctime((const time_t *)&entry.mod_date),
 	  DATE_SZ);
   princ->attributes = entry.attributes;
   princ->max_life = entry.max_life;

home help back first fref pref prev next nref lref last post