[1263] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

Kerberos 5-B4-pl3 bug report (libtelnet/kerberos5.c)

daemon@ATHENA.MIT.EDU (Craig Leres)
Fri Mar 24 05:19:40 1995

To: krb5-bugs@MIT.EDU, dab@cray.com
Cc: hobbit@asylum.sf.ca.us, mike@fionn.lbl.gov (Michael Helm)
Date: Fri, 24 Mar 95 02:19:33 PST
From: Craig Leres <leres@ee.lbl.gov>

I happened to notice (thanks to gcc) that kerberos5_send() was passing
the wrong argument to krb5_copy_keyblock_contents(). I'm not sure what
the symptoms of this would be.

While I was at it, I ifdef'ed out some code that gcc 2.6 was
complaining about.

Context diffs appended.

		Craig
------
RCS file: RCS/kerberos5.c,v
retrieving revision 1.2
diff -c -r1.2 kerberos5.c
*** /tmp/,RCSt1a27519	Fri Mar 24 02:13:57 1995
--- kerberos5.c	Fri Mar 24 02:13:53 1995
***************
*** 270,278 ****
  	    if (newkey->keytype != KEYTYPE_DES) {
  		if (creds.keyblock.keytype == KEYTYPE_DES)
  		    /* use the session key in credentials instead */
! 		    krb5_copy_keyblock_contents(&creds, &session_key);
  		else
  		    /* XXX ? */;
  	    } else {
  		krb5_copy_keyblock_contents(newkey, &session_key);
  	    }
--- 270,280 ----
  	    if (newkey->keytype != KEYTYPE_DES) {
  		if (creds.keyblock.keytype == KEYTYPE_DES)
  		    /* use the session key in credentials instead */
! 		    krb5_copy_keyblock_contents(&creds.keyblock, &session_key);
! #ifdef notdef
  		else
  		    /* XXX ? */;
+ #endif
  	    } else {
  		krb5_copy_keyblock_contents(newkey, &session_key);
  	    }

home help back first fref pref prev next nref lref last post