[1258] in Kerberos-V5-bugs
krb5b4pl3: popper: some minor logging changes
daemon@ATHENA.MIT.EDU (Jonathan I. Kamens)
Thu Mar 23 16:13:18 1995
From: "Jonathan I. Kamens" <jik@cam.ov.com>
Date: Thu, 23 Mar 1995 16:16:11 -0500
To: krb5-bugs@MIT.EDU
Two changes to the logging code in the popper included with krb5b4pl3
(perhaps these should be submitted back to the original authors of the
popper, but I leave that up to you guys....):
1. When debugging is enabled, log all messages, not just messages
indicating success. That is, after all, the whole point of
debugging. The administrator can control which messages actually
get saved somewhere using syslog.conf.
2. Include the PID in syslog messages, since multiple popper processes
run at the same time (and the PID is therefore necessary to be able
to distinguish between them in the log file).
--- pop_msg.c 1995/03/23 21:13:49 1.1
+++ pop_msg.c 1995/03/23 21:13:54
@@ -62,7 +62,7 @@
/* Log the message if debugging is turned on */
#ifdef DEBUG
- if (p->debug && stat == POP_SUCCESS)
+ if (p->debug)
pop_log(p,POP_DEBUG,"%s",message);
#endif
--- popper.h 1995/03/23 21:12:47 1.1
+++ popper.h 1995/03/23 21:12:52
@@ -40,7 +40,7 @@
#define POP_PRIORITY LOG_NOTICE
#define POP_INFO LOG_INFO
#define POP_DEBUG LOG_DEBUG
-#define POP_LOGOPTS 0
+#define POP_LOGOPTS LOG_PID
#ifdef POP_PVT_PASSWD
#ifndef POP_PASSFILE
