[1166] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

krb5b4pl3: appl/bsd/krsh.c: debug_port needs to be htons()'d

daemon@ATHENA.MIT.EDU (Jonathan I. Kamens)
Tue Mar 14 13:52:59 1995

From: "Jonathan I. Kamens" <jik@cam.ov.com>
Date: Tue, 14 Mar 1995 13:56:08 -0500
To: krb5-bugs@MIT.EDU

Changing debug_port from int to short is debatable, I guess, because
short might be an eight-bit quantity on some systems.  The second
patch, however, is required regardless of the first patch (I believe).

--- appl/bsd/krsh.c	1995/03/13 00:19:32	1.4
+++ appl/bsd/krsh.c	1995/03/14 13:59:00	1.5
@@ -109,7 +109,7 @@
     krb5_error_code status;
     int fflag = 0, Fflag = 0;
     int xflag = 0;
-    int debug_port = 0;
+    short debug_port = 0;
 #endif  /* KERBEROS */
    
     if (strrchr(argv[0], '/'))
@@ -297,7 +297,7 @@
 
 #ifdef KERBEROS
     if (debug_port)
-      sp->s_port = debug_port;
+      sp->s_port = htons(debug_port);
     
     krb5_init_ets();
     authopts = AP_OPTS_MUTUAL_REQUIRED;

home help back first fref pref prev next nref lref last post