[11641] in Kerberos-V5-bugs
[krbdev.mit.edu #6753] SVN Commit
daemon@ATHENA.MIT.EDU (Greg Hudson via RT)
Mon Jul 26 14:19:00 2010
Mail-followup-to: rt@krbdev.mit.edu
mail-copies-to: never
From: "Greg Hudson via RT" <rt-comment@krbdev.MIT.EDU>
In-Reply-To: <rt-6753@krbdev.mit.edu>
Message-ID: <rt-6753-33055.3.5719649175396@krbdev.mit.edu>
To: "'AdminCc of krbdev.mit.edu Ticket #6753'":;"'AdminCc of krbdev.mit.edu Ticket #6753'":;@MIT.EDU
Date: Mon, 26 Jul 2010 14:18:58 -0400 (EDT)
Reply-To: rt-comment@krbdev.MIT.EDU
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krb5-bugs-bounces@mit.edu
Our ancient RPC value internally decodes 32-bit wire values into a
signed long, which is then casted to the appropriate type.
xdr_u_int() contains a check intended to catch wire values that don't
fit into a u_int on platforms with 16-ints, but on platforms with
64-bit longs it was failing on values of 2^31 or larger because the
sign-extended value appeared larger than UINT_MAX. Fix the check by
casting the value to uint32_t before comparing.
This bug, in combination with a poor choice of types in
kadm_rpc_xdr.c's xdr_krb5_enctype(), prevented negative enctype values
from being transported properly in kadmin's change_password command
result.
http://src.mit.edu/fisheye/changelog/krb5/?cs=24210
Commit By: ghudson
Revision: 24210
Changed Files:
U trunk/src/lib/rpc/xdr.c
_______________________________________________
krb5-bugs mailing list
krb5-bugs@mit.edu
https://mailman.mit.edu/mailman/listinfo/krb5-bugs