[1162] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

krb5b4pl3: appl/bsd/krlogind.c: LOG_AUTH shouldn't be in second argument to 4.3 openlog

daemon@ATHENA.MIT.EDU (Jonathan I. Kamens)
Tue Mar 14 11:16:21 1995

From: "Jonathan I. Kamens" <jik@cam.ov.com>
Date: Tue, 14 Mar 1995 11:19:04 -0500
To: krb5-bugs@MIT.EDU

When calling 4.3 openlog(), you can't make LOG_AUTH part of the mask
of the second argument, because the constant value of LOG_AUTH may
also be one of the mask bits that's assigned meaning.  For example,
under Linux, which is probably the same in this regard as any 4.3net2
system, LOG_PERROR has the same value as LOG_AUTH.

--- appl/bsd/krlogind.c	1995/03/09 22:03:57	1.6
+++ appl/bsd/krlogind.c	1995/03/09 22:05:52	1.7
@@ -329,7 +329,7 @@
 #ifndef LOG_AUTH /* 4.2 syslog */
     openlog(progname, LOG_PID|LOG_NDELAY);
 #else
-    openlog(progname, LOG_PID | LOG_AUTH | LOG_NDELAY, LOG_AUTH);
+    openlog(progname, LOG_PID | LOG_NDELAY, LOG_AUTH);
 #endif /* 4.2 syslog */
     
 #else /* ! KERBEROS */
@@ -337,7 +337,7 @@
 #ifndef LOG_AUTH /* 4.2 syslog */
     openlog("rlogind", LOG_PID| LOG_NDELAY);
 #else
-    openlog("rlogind", LOG_PID | LOG_AUTH | LOG_NDELAY, LOG_AUTH);
+    openlog("rlogind", LOG_PID | LOG_NDELAY, LOG_AUTH);
 #endif /* 4.2 syslog */
     
 #endif /* KERBEROS */

home help back first fref pref prev next nref lref last post