[11435] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

[krbdev.mit.edu #6674] memory leak in SPNEGO

daemon@ATHENA.MIT.EDU (Arlene Berry" via RT)
Fri Mar 5 00:41:39 2010

Mail-followup-to: rt@krbdev.mit.edu
mail-copies-to: never
From: ""Arlene Berry" via RT" <rt-comment@krbdev.MIT.EDU>
In-Reply-To: <rt-6674@krbdev.mit.edu>
Message-ID: <rt-6674-32550.15.2718019677739@krbdev.mit.edu>
To: "'AdminCc of krbdev.mit.edu Ticket #6674'":;"'AdminCc of krbdev.mit.edu Ticket #6674'":;@MIT.EDU
Date: Fri,  5 Mar 2010 00:41:21 -0500 (EST)
Reply-To: rt-comment@krbdev.MIT.EDU
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krb5-bugs-bounces@mit.edu

We caught a memory leak in SPNEGO.  This fixed it for us:

Index: src/lib/gssapi/spnego/spnego_mech.c
===================================================================
--- src/lib/gssapi/spnego/spnego_mech.c	(revision 23762)
+++ src/lib/gssapi/spnego/spnego_mech.c	(working copy)
@@ -1739,9 +1739,12 @@
 	}
 	if (ret == GSS_S_COMPLETE) {
 		*context_handle = (gss_ctx_id_t)sc->ctx_handle;
-		if (sc->internal_name != GSS_C_NO_NAME &&
-		    src_name != NULL) {
+		if (sc->internal_name != GSS_C_NO_NAME) {
+                    if (src_name != NULL) {
 			*src_name = sc->internal_name;
+                    } else {
+                        gss_release_name(&tmpmin, &sc->internal_name);
+                    }
 		}
 		release_spnego_ctx(&sc);
 	} else if (ret != GSS_S_CONTINUE_NEEDED) {


_______________________________________________
krb5-bugs mailing list
krb5-bugs@mit.edu
https://mailman.mit.edu/mailman/listinfo/krb5-bugs

home help back first fref pref prev next nref lref last post