[11398] in Kerberos-V5-bugs
[krbdev.mit.edu #6656] SVN Commit
daemon@ATHENA.MIT.EDU (Tom Yu via RT)
Fri Feb 12 15:28:44 2010
Mail-followup-to: rt@krbdev.mit.edu
mail-copies-to: never
From: "Tom Yu via RT" <rt-comment@krbdev.MIT.EDU>
In-Reply-To: <rt-6656@krbdev.mit.edu>
Message-ID: <rt-6656-32456.13.3591015458321@krbdev.mit.edu>
To: "'AdminCc of krbdev.mit.edu Ticket #6656'":;"'AdminCc of krbdev.mit.edu Ticket #6656'":;@MIT.EDU
Date: Fri, 12 Feb 2010 15:28:40 -0500 (EST)
Reply-To: rt-comment@krbdev.MIT.EDU
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krb5-bugs-bounces@mit.edu
pull up r23712, r23714 from trunk
------------------------------------------------------------------------
r23714 | ghudson | 2010-02-09 20:55:36 -0500 (Tue, 09 Feb 2010) | 13 lines
ticket: 6656
Followon fixes to r23712:
* A few formatting fixes.
* Fix unlikely leak in kdc_handle_protected_negotiation: if
add_pa_data_element with copy == FALSE fails, it's still the
caller's responsibility to free pa.contents.
* Fix pre-existing (since r23465) leak of reply_encpart.enc_padata in
process_as_req.
* Call add_pa_data_element with copy == TRUE in
return_referral_enc_padata since we are passing memory owned by the
database entry.
------------------------------------------------------------------------
r23712 | hartmans | 2010-02-09 14:15:07 -0500 (Tue, 09 Feb 2010) | 14 lines
subject: enc_padata can include empty sequence
ticket: 6656
target_version: 1.8
tags: pullup
There are two issues with return_enc_padata.
1) It often will return an empty sequence of enc_padata rather than not including the field
2) FAST negotiation is double supported in the referral tgs path and not supported in the non-referral path
Rewrite the return_enc_padata logic to:
* Split out referral interactions with kdb into its own function
* Use add_pa_data_element
http://src.mit.edu/fisheye/changelog/krb5/?cs=23718
Commit By: tlyu
Revision: 23718
Changed Files:
U branches/krb5-1-8/src/kdc/do_as_req.c
U branches/krb5-1-8/src/kdc/do_tgs_req.c
U branches/krb5-1-8/src/kdc/kdc_preauth.c
U branches/krb5-1-8/src/kdc/kdc_util.c
U branches/krb5-1-8/src/kdc/kdc_util.h
_______________________________________________
krb5-bugs mailing list
krb5-bugs@mit.edu
https://mailman.mit.edu/mailman/listinfo/krb5-bugs
