[11277] in Kerberos-V5-bugs
[krbdev.mit.edu #6618] Support optional creation of PID files for
daemon@ATHENA.MIT.EDU (Greg Hudson via RT)
Fri Jan 1 00:08:03 2010
Mail-followup-to: rt@krbdev.mit.edu
mail-copies-to: never
From: "Greg Hudson via RT" <rt-comment@krbdev.MIT.EDU>
In-Reply-To: <rt-6618@krbdev.mit.edu>
Message-ID: <rt-6618-31975.1.14875450586247@krbdev.mit.edu>
To: "'AdminCc of krbdev.mit.edu Ticket #6618'":;"'AdminCc of krbdev.mit.edu Ticket #6618'":;@MIT.EDU
Date: Fri, 1 Jan 2010 00:07:51 -0500 (EST)
Reply-To: rt-comment@krbdev.MIT.EDU
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krb5-bugs-bounces@mit.edu
This looks fine. (I would have put the conditional on pid_file == NULL
into the helper, but it doesn't really matter.) I looked over the
source to some other open-source daemons and it didn't look like
treating the pid file as a lock file is terribly common, so I think
simply writing out the pid unconditionally is fine.
_______________________________________________
krb5-bugs mailing list
krb5-bugs@mit.edu
https://mailman.mit.edu/mailman/listinfo/krb5-bugs
