[11194] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

[krbdev.mit.edu #6571] krb5 1.7 memory leak

daemon@ATHENA.MIT.EDU (Arlene Berry " via RT)
Fri Oct 9 00:11:14 2009

Mail-Followup-To: rt@krbdev.mit.edu
mail-copies-to: never
From: "" Arlene Berry " via RT" <rt-comment@krbdev.MIT.EDU>
In-Reply-To: <rt-6571@krbdev.mit.edu>
Message-ID: <rt-6571-31800.11.9359297078515@krbdev.mit.edu>
To: "'AdminCc of krbdev.mit.edu Ticket #6571'":;"'AdminCc of krbdev.mit.edu Ticket #6571'":;@MIT.EDU
Date: Thu,  8 Oct 2009 22:03:01 +0000 (UTC)
Reply-To: rt-comment@krbdev.MIT.EDU
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krb5-bugs-bounces@mit.edu

The enc_padata field that was added to the krb5_enc_kdc_rep_part
structure for 1.7 is being leaked.  Our fix is below.  It looks like the
second change was done in trunk when the S4U changes were merged.

Modified: src/lib/krb5/asn.1/asn1_k_decode.c
===================================================================
--- src/lib/krb5/asn.1/asn1_k_decode.c	2009-10-07 22:25:00 UTC (rev
37774)
+++ src/lib/krb5/asn.1/asn1_k_decode.c	2009-10-07 22:27:28 UTC (rev
37775)
@@ -668,6 +668,7 @@
     krb5_free_last_req(NULL, val->last_req);
     krb5_free_principal(NULL, val->server);
     krb5_free_addresses(NULL, val->caddrs);
+    krb5_free_pa_data(NULL, val->enc_padata);
     val->session = NULL;
     val->last_req = NULL;
     val->server = NULL;

Modified: src/lib/krb5/krb/kfree.c
===================================================================
--- src/lib/krb5/krb/kfree.c	2009-10-07 22:25:00 UTC (rev 37774)
+++ src/lib/krb5/krb/kfree.c	2009-10-07 22:27:28 UTC (rev 37775)
@@ -297,6 +297,7 @@
     krb5_free_last_req(context, val->last_req);
     krb5_free_principal(context, val->server);
     krb5_free_addresses(context, val->caddrs);
+    krb5_free_pa_data(context, val->enc_padata);
     free(val);
 }


_______________________________________________
krb5-bugs mailing list
krb5-bugs@mit.edu
https://mailman.mit.edu/mailman/listinfo/krb5-bugs

home help back first fref pref prev next nref lref last post