[1105] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

Kerberos 5-B4-pl3 bug report (telnet/telnet.c)

daemon@ATHENA.MIT.EDU (Craig Leres)
Thu Feb 23 20:58:17 1995

To: krb5-bugs@MIT.EDU, dab@cray.com
Cc: hobbit@asylum.sf.ca.us, jef@ee.lbl.gov (Jef Poskanzer)
Date: Thu, 23 Feb 95 17:58:03 PST
From: Craig Leres <leres@ee.lbl.gov>

While running under Solaris 2.4 (aka SunOS 5.4) with the -E flag (no
escape character) we found that telnet would enter command mode on NULL
(which h)(e.g. control-space on a Sun workstation). This is because
_POSIX_VDISABLE is zero under Solaris. I believe the fix is to test the
escape character against _POSIX_VDISABLE.

Context diffs appended.

		Craig
------
*** kerberosV.virgin/src/appl/telnet/telnet/telnet.c	Thu Aug 18 14:07:49 1994
--- kerberosV/src/appl/telnet/telnet/telnet.c	Thu Feb 23 17:55:29 1995
***************
*** 2052,2058 ****
  				command(0, "z\n", 2);
  				continue;
  			}
! 			if (sc == escape) {
  				command(0, (char *)tbp, tcc);
  				bol = 1;
  				count += tcc;
--- 2052,2058 ----
  				command(0, "z\n", 2);
  				continue;
  			}
! 			if (sc == escape && escape != _POSIX_VDISABLE) {
  				command(0, (char *)tbp, tcc);
  				bol = 1;
  				count += tcc;
***************
*** 2069,2075 ****
  		}
  		if ((sc == '\n') || (sc == '\r'))
  			bol = 1;
! 	} else if (sc == escape) {
  	    /*
  	     * Double escape is a pass through of a single escape character.
  	     */
--- 2069,2075 ----
  		}
  		if ((sc == '\n') || (sc == '\r'))
  			bol = 1;
! 	} else if (sc == escape && escape != _POSIX_VDISABLE) {
  	    /*
  	     * Double escape is a pass through of a single escape character.
  	     */

home help back first fref pref prev next nref lref last post