[1070] in Kerberos-V5-bugs
No subject found in mail header
daemon@ATHENA.MIT.EDU (epeisach@MIT.EDU)
Sat Feb 4 22:37:24 1995
From: epeisach@MIT.EDU
Date: Sat, 4 Feb 1995 22:37:19 -0500
To: krb5-bugs@MIT.EDU
The following is based on the definition of authorization_data in
lib/krb5/krb/send_tgs.c (krb5_send_tgs) where it is defined as:
krb5_authdata * const * authorization_data;
which I believe is correct....
If so, the following consequences arise as
changes in prototypes.... and source code...
One may be able to argue that
retval = asn1_encode_authorization_data(buf,(const krb5_authdata**)rep,
should also be changed...
Hmm... thinking about it some more, maybe the definition of
authorization_data is wrong.... A pointer to a constant pointer to a
krb5_authdata... Maybe const krb5_authdata ** is right....
Can someone who understands this, choose the right choice.... (and fix
either the send_tgs code or the below code)....
Ezra
===================================================================
RCS file: /mit/krb5/.cvsroot/src/lib/krb5/asn.1/krb5_encode.c,v
retrieving revision 5.7
diff -c -r5.7 krb5_encode.c
*** 5.7 1995/02/03 09:06:26
--- krb5_encode.c 1995/02/05 03:17:24
***************
*** 678,684 ****
}
krb5_error_code encode_krb5_authdata(rep, code)
! const krb5_authdata ** rep;
krb5_data ** code;
{
asn1_error_code retval;
--- 678,684 ----
}
krb5_error_code encode_krb5_authdata(rep, code)
! krb5_authdata * const * rep;
krb5_data ** code;
{
asn1_error_code retval;
===================================================================
RCS file: /mit/krb5/.cvsroot/src/lib/krb5/asn.1/krb5_encode.h,v
retrieving revision 5.2
diff -c -r5.2 krb5_encode.h
*** 5.2 1994/07/14 15:44:15
--- krb5_encode.h 1995/02/05 03:13:53
***************
*** 95,101 ****
PROTOTYPE((const krb5_error *rep, krb5_data **code));
krb5_error_code encode_krb5_authdata
! PROTOTYPE((const krb5_authdata **rep, krb5_data **code));
krb5_error_code encode_krb5_pwd_sequence
PROTOTYPE((const passwd_phrase_element *rep, krb5_data **code));
--- 95,101 ----
PROTOTYPE((const krb5_error *rep, krb5_data **code));
krb5_error_code encode_krb5_authdata
! PROTOTYPE((krb5_authdata * const *rep, krb5_data **code));
krb5_error_code encode_krb5_pwd_sequence
PROTOTYPE((const passwd_phrase_element *rep, krb5_data **code));
===================================================================
RCS file: /mit/krb5/.cvsroot/src/tests/asn.1/krb5_encode_test.c,v
retrieving revision 1.6
diff -c -r1.6 krb5_encode_test.c
*** 1.6 1995/01/13 22:05:09
--- krb5_encode_test.c 1995/02/05 03:22:05
***************
*** 415,421 ****
krb5_authdata **ad;
setup(ad,authorization_data,"authorization_data",ktest_make_sample_authorization_data);
! retval = encode_krb5_authdata((const krb5_authdata**)ad,&(code));
if(retval) com_err("encoding authorization_data",retval,"");
encoder_print_results(code, "authorization_data", "");
}
--- 415,421 ----
krb5_authdata **ad;
setup(ad,authorization_data,"authorization_data",ktest_make_sample_authorization_data);
! retval = encode_krb5_authdata((krb5_authdata * const *)ad,&(code));
if(retval) com_err("encoding authorization_data",retval,"");
encoder_print_results(code, "authorization_data", "");
}
