[1067] in Kerberos-V5-bugs

home help back first fref pref prev next nref lref last post

Current sources kadmin/v4server bug

daemon@ATHENA.MIT.EDU (epeisach@MIT.EDU)
Sat Feb 4 21:51:13 1995

From: epeisach@MIT.EDU
Date: Sat, 4 Feb 1995 21:51:03 -0500
To: krb5-bugs@MIT.EDU


Looking at prototype errors turned up these....

The int vs. krb5_boolean probably will not matter, but the second
argument to krb5_db_delete_principal is a principal, not an entry... I
guess no one tested the code....

	Ezra

===================================================================
RCS file: /mit/krb5/.cvsroot/src/kadmin/v4server/kadm_funcs.c,v
retrieving revision 1.15
diff -c -r1.15 kadm_funcs.c
*** 1.15	1995/01/26 04:02:02
--- kadm_funcs.c	1995/02/04 23:21:05
***************
*** 294,300 ****
  Kadm_vals *valsout;
  {
    int numfound;			/* check how many we get written */
!   int more;			/* pointer to more grabbed records */
    Principal data_i, data_o;		/* temporary principal */
    u_char flags[4];
    krb5_db_entry entry, odata;
--- 294,300 ----
  Kadm_vals *valsout;
  {
    int numfound;			/* check how many we get written */
!   krb5_boolean more;			/* pointer to more grabbed records */
    Principal data_i, data_o;		/* temporary principal */
    u_char flags[4];
    krb5_db_entry entry, odata;
***************
*** 332,338 ****
      faildel(KADM_NOENTRY);
    }
  
!   retval = krb5_db_delete_principal(kadm_context, &entry, &numfound);
    if (retval) {
      krb5_db_free_principal(kadm_context, &entry, numfound);
      faildel(retval);
--- 332,338 ----
      faildel(KADM_NOENTRY);
    }
  
!   retval = krb5_db_delete_principal(kadm_context, inprinc, &numfound);
    if (retval) {
      krb5_db_free_principal(kadm_context, &entry, numfound);
      faildel(retval);

home help back first fref pref prev next nref lref last post