[38342] in Kerberos

home help back first fref pref prev next nref lref last post

Re: non-POSIX use in yacc with getdate.y

daemon@ATHENA.MIT.EDU (Robbie Harwood)
Wed Sep 26 12:44:12 2018

From: Robbie Harwood <rharwood@redhat.com>
To: "Osipov\, Michael" <michael.osipov@siemens.com>, kerberos@mit.edu
In-Reply-To: <6a7132a9-0df6-c783-1c6b-0a055a3621dc@siemens.com>
Date: Wed, 26 Sep 2018 12:43:44 -0400
Message-ID: <jlgmus42oqn.fsf@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9067085500014979252=="
Errors-To: kerberos-bounces@mit.edu

--===============9067085500014979252==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

"Osipov, Michael" <michael.osipov@siemens.com> writes:

> Am 2018-09-25 um 19:25 schrieb Robbie Harwood:
>> "Osipov, Michael" <michael.osipov@siemens.com> writes:
>>=20
>>> Hi folks,
>>>
>>> I have recently compiled MIT Kerberos 1.16.1 on HP-UX and yacc failed w=
ith:
>>>
>>>> "./kadmin/cli/getdate.y", line 180: fatal error: invalid escape, or il=
legal reserved word: expect
>>>
>>> Change introduced in
>>> https://github.com/krb5/krb5/commit/28fd0a934cdc7b3b42ce213c6d334d4edf1=
ab591#diff-db7f4e6f3883dd26b97f7b3e10697846R180.
>>>
>>> I contacted HPE about this and it turned out that their yacc
>>> implementation does not support extensions as the GNU or BSD
>>> counterparts do.
>>>
>>> I'd like to have this fixed somehow and there are several ways to do th=
is:
>>>
>>> * Remove this line manually before compiling on the platform which does
>>> not support this "%expect" extension
>>> * Revert the commit and live with the verbose output
>>> * Test for this extension in the configure.ac script
>>> * Require GNU bison if yacc is POSIX only. Note I am reluctant to this
>>> because this is merely one line for less verbose output?
>>>
>>> Any comments from the devs?
>>=20
>> As the author of the change, it wasn't my intent to mandate GNU bison
>> here.  Platform checking/configure tests seem like overkill for just a
>> warning.  The intent was to get the codebase to be warning-free on clang
>> on Travis to help with code reviews.
>
> Hi Robbie,
>
> I never assumed anything else ;-) Bison also has a YACC mode with '-y',=20
> but I do not know whether extensions will be disabled.
>
>> I've opened https://github.com/krb5/krb5/pull/849 to revert this change.
>
> Looks promising, but I would leave the %expect as a comment and add a=20
> comment above why we cannot enable this.

Sounds reasonable; updated.

Thanks,
=2D-Robbie

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEA5qc6hnelQjDaHWqJTL5F2qVpEIFAlurt0AACgkQJTL5F2qV
pEJNkw//beoyxp43lHJ/8T4TqaYwCJKZCiLAmWM8M28HFfdnIZ/gsKlfrizfPVYs
biRhLkntEF4Y6zxMz7YSyzy3elCBCbbHpDZk5NI2pZnW+ENW9nzF2fECcupIubZ7
z1jVbk9yHL9YpjHyWxOVJTpAhOEvNB9xHeY6Uo/dJjYj1Z2NZ0YXs4YYY6/InVzH
SFlYYYBalaYfyF1j1NWOmYIUsXrC9XTSiUqM+IA90a68JzwY3YmxkoLjgpflXDn5
tjSIy8aBwq//+aoj0mj1rBjGojMsDfXUfi7qceX56DsLVcPatc6yv/LmOLBFfL+C
9lsjz/O9OHRMhBI3KDLE3+d+iw8Mw1EHxl+XjwFXigK7epv/+WsUrNGaONyvULRQ
7PCa9arZ1yE4ziMttjj9phwMOsdpckGVq9Hmw5yzLh7s1v4TZ9mO4WNp5PwSgopI
SbhGR66IoNTY7Jri23NouZ/+PTxRjKgdryDzZXw7I6vDToX+mBCZ+r8CZ6TeP2PW
bucqwtaS85e6vER0whsrzPSFSzaj8rhA/wik3gTAF1n595vtyQG0i6BikaN1X+xt
VFHKIM/40qp6NYszP0Ar3qIwyjJJQVcMarfupP8dNxafaW4cngnBrnkX+JGFJkQk
6i9lhK3ob0QP/dBLu+uZOKiqadhDbWaCGxJ+8LjvKRXx/t9/HYc=
=DT1G
-----END PGP SIGNATURE-----
--=-=-=--

--===============9067085500014979252==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

________________________________________________
Kerberos mailing list           Kerberos@mit.edu
https://mailman.mit.edu/mailman/listinfo/kerberos

--===============9067085500014979252==--

home help back first fref pref prev next nref lref last post