[31426] in CVS-changelog-for-Kerberos-V5

home help back first fref pref prev next nref lref last post

krb5 commit: Fix kdb5_util ark with no -e option

daemon@ATHENA.MIT.EDU (ghudson@mit.edu)
Fri Apr 25 01:07:37 2025

From: ghudson@mit.edu
To: cvs-krb5@mit.edu
Message-Id: <20250425050731.CE005102CE2@krbdev.mit.edu>
Date: Fri, 25 Apr 2025 01:07:31 -0400 (EDT)
MIME-Version: 1.0
Reply-To: krbdev@mit.edu
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu

https://github.com/krb5/krb5/commit/edbd493a3ea5fcba195f65e142509a3cd1d73e83
commit edbd493a3ea5fcba195f65e142509a3cd1d73e83
Author: Greg Hudson <ghudson@mit.edu>
Date:   Fri Apr 18 02:59:33 2025 -0400

    Fix kdb5_util ark with no -e option
    
    Avoid passing NULL to krb5_string_to_keysalt() in add_random_key().
    When add_random_key() was first written, krb5_string_to_keysalts() did
    nothing on a null string input.  After commit
    3576bd662be9b7cc2cca97065fe467e745542b69 it calls strdup(NULL) and
    crashes.

 src/kadmin/dbutil/kdb5_util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/kadmin/dbutil/kdb5_util.c b/src/kadmin/dbutil/kdb5_util.c
index 88218dba7..96b4a2571 100644
--- a/src/kadmin/dbutil/kdb5_util.c
+++ b/src/kadmin/dbutil/kdb5_util.c
@@ -522,7 +522,7 @@ add_random_key(int argc, char **argv)
 
     int free_keysalts;
     char *me = progname;
-    char *ks_str = NULL;
+    char *ks_str = "";
     char *pr_str;
     krb5_keyblock *tmp_mkey;
 
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5

home help back first fref pref prev next nref lref last post