[31276] in CVS-changelog-for-Kerberos-V5
krb5 commit: Fix krb5_cccol_have_content() bad pointer free
daemon@ATHENA.MIT.EDU (ghudson@mit.edu)
Sat Sep 2 22:37:04 2023
From: ghudson@mit.edu
To: <cvs-krb5@mit.edu>
Message-ID: <20230903023656.4F86E1016FC@krbdev.mit.edu>
Date: Sat, 2 Sep 2023 22:36:56 -0400 (EDT)
MIME-Version: 1.0
Reply-To: krbdev@mit.edu
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/635c8cca65b745476d07c1f5ff701445db25c10d
commit 635c8cca65b745476d07c1f5ff701445db25c10d
Author: Ilya Gladyshev <ilya.v.gladyshev@gmail.com>
Date: Wed Aug 30 21:19:59 2023 +0100
Fix krb5_cccol_have_content() bad pointer free
krb5_cccol_have_content() calls krb5_cc_get_principal() within a loop,
and frees the resulting principal on success or failure. Set princ to
null before each call to ensure we don't free a dangling pointer.
[ghudson@mit.edu: rewrote commit message; moved assignment for greater
clarity]
ticket: 9103
tags: pullup
target_version: 1.21-next
target_version: 1.20-next
src/lib/krb5/ccache/cccursor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/lib/krb5/ccache/cccursor.c b/src/lib/krb5/ccache/cccursor.c
index 4bcb66b71..926873f2a 100644
--- a/src/lib/krb5/ccache/cccursor.c
+++ b/src/lib/krb5/ccache/cccursor.c
@@ -249,6 +249,7 @@ krb5_cccol_have_content(krb5_context context)
save_first_error(context, ret, &errsave);
if (ret || cache == NULL)
break;
+ princ = NULL;
ret = krb5_cc_get_principal(context, cache, &princ);
save_first_error(context, ret, &errsave);
if (!ret)
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
