[31012] in CVS-changelog-for-Kerberos-V5
krb5 commit: Clean up context after failed open in libkdb5
daemon@ATHENA.MIT.EDU (Greg Hudson)
Mon Jun 28 12:33:17 2021
Date: Mon, 28 Jun 2021 12:30:48 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-ID: <202106281630.15SGUmbr031516@drugstore.mit.edu>
To: <cvs-krb5@mit.edu>
MIME-Version: 1.0
Reply-To: krbdev@mit.edu
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/849b7056e703bd3724d909263769ce190db59acc
commit 849b7056e703bd3724d909263769ce190db59acc
Author: Greg Hudson <ghudson@mit.edu>
Date: Wed Jun 23 16:57:39 2021 -0400
Clean up context after failed open in libkdb5
If krb5_db_open() or krb5_db_create() fails, release the dal_handle,
as the caller is unlikely to call krb5_db_close() after a failure.
src/lib/kdb/kdb5.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/src/lib/kdb/kdb5.c b/src/lib/kdb/kdb5.c
index 47e9b31..11e2430 100644
--- a/src/lib/kdb/kdb5.c
+++ b/src/lib/kdb/kdb5.c
@@ -675,6 +675,8 @@ krb5_db_open(krb5_context kcontext, char **db_args, int mode)
return status;
status = v->init_module(kcontext, section, db_args, mode);
free(section);
+ if (status)
+ (void)krb5_db_fini(kcontext);
return status;
}
@@ -702,6 +704,8 @@ krb5_db_create(krb5_context kcontext, char **db_args)
return status;
status = v->create(kcontext, section, db_args);
free(section);
+ if (status)
+ (void)krb5_db_fini(kcontext);
return status;
}
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
