[30643] in CVS-changelog-for-Kerberos-V5
krb5 commit [krb5-1.17]: Fix KCM client time offset propagation
daemon@ATHENA.MIT.EDU (Greg Hudson)
Mon Dec 9 18:23:59 2019
Date: Mon, 9 Dec 2019 18:23:53 -0500
From: Greg Hudson <ghudson@mit.edu>
Message-ID: <201912092323.xB9NNrX3020005@drugstore.mit.edu>
To: <cvs-krb5@mit.edu>
MIME-Version: 1.0
Reply-To: krbdev@mit.edu
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/3a32b06e10088ce6ef862cf454fa3e8f8b32db7d
commit 3a32b06e10088ce6ef862cf454fa3e8f8b32db7d
Author: Robbie Harwood <rharwood@redhat.com>
Date: Wed Aug 14 13:52:27 2019 -0400
Fix KCM client time offset propagation
An inverted status check in get_kdc_offset() would cause querying the
offset time from the ccache to always fail (silently) on KCM. Fix the
status check so that KCM can properly handle desync.
(cherry picked from commit 323abb6d1ebe5469d6c2167c29aa5d696d099b90)
ticket: 8826
version_fixed: 1.17.1
src/lib/krb5/ccache/cc_kcm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/lib/krb5/ccache/cc_kcm.c b/src/lib/krb5/ccache/cc_kcm.c
index 092ab7d..fe93ca3 100644
--- a/src/lib/krb5/ccache/cc_kcm.c
+++ b/src/lib/krb5/ccache/cc_kcm.c
@@ -583,7 +583,7 @@ get_kdc_offset(krb5_context context, krb5_ccache cache)
if (cache_call(context, cache, &req, FALSE) != 0)
goto cleanup;
time_offset = k5_input_get_uint32_be(&req.reply);
- if (!req.reply.status)
+ if (req.reply.status)
goto cleanup;
context->os_context.time_offset = time_offset;
context->os_context.usec_offset = 0;
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
