[30593] in CVS-changelog-for-Kerberos-V5
krb5 commit: Accept GSS mechs which don't supply attributes
daemon@ATHENA.MIT.EDU (Greg Hudson)
Mon Oct 21 17:26:27 2019
Date: Mon, 21 Oct 2019 17:25:52 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-ID: <201910212125.x9LLPqGV007349@drugstore.mit.edu>
To: <cvs-krb5@mit.edu>
MIME-Version: 1.0
Reply-To: krbdev@mit.edu
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/bd321c9caa6dc4b034bc3279a1af39af4c41210d
commit bd321c9caa6dc4b034bc3279a1af39af4c41210d
Author: Greg Hudson <ghudson@mit.edu>
Date: Sun Oct 6 18:35:50 2019 -0400
Accept GSS mechs which don't supply attributes
If gss_inquire_attrs_for_mech() is called for a mechanism which does
not implement it, the call will succeed with mech_attrs set to
GSS_C_NO_OID_SET (as is explicitly allowed by RFC 5587).
generic_gss_test_oid_set_member() returns an error on this value,
causing gss_accept_sec_context() to erroneously deny the mechanism
when no verifier credential handle is supplied. Change
allow_mech_by_default() to explicitly check for no mech attribute set.
ticket: 8840 (new)
tags: pullup
target_version: 1.17-next
target_version: 1.16-next
src/lib/gssapi/mechglue/g_accept_sec_context.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/src/lib/gssapi/mechglue/g_accept_sec_context.c b/src/lib/gssapi/mechglue/g_accept_sec_context.c
index f28e2b1..1a03cf4 100644
--- a/src/lib/gssapi/mechglue/g_accept_sec_context.c
+++ b/src/lib/gssapi/mechglue/g_accept_sec_context.c
@@ -104,6 +104,10 @@ allow_mech_by_default(gss_OID mech)
if (status)
return 0;
+ /* If the mechanism doesn't support RFC 5587, don't exclude it. */
+ if (attrs == GSS_C_NO_OID_SET)
+ return 1;
+
/* Check for each attribute which would cause us to exclude this mech from
* the default credential. */
if (generic_gss_test_oid_set_member(&minor, GSS_C_MA_DEPRECATED,
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
