[30586] in CVS-changelog-for-Kerberos-V5

home help back first fref pref prev next nref lref last post

krb5 commit: Follow-up on krb5_gss_duplicate_name() null check

daemon@ATHENA.MIT.EDU (Greg Hudson)
Tue Sep 24 02:01:46 2019

Date: Tue, 24 Sep 2019 02:01:17 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-ID: <201909240601.x8O61HYu023501@drugstore.mit.edu>
To: <cvs-krb5@mit.edu>
MIME-Version: 1.0
Reply-To: krbdev@mit.edu
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu

https://github.com/krb5/krb5/commit/e8a932e2bdf822c655fa8faebd23f3f0fd756dab
commit e8a932e2bdf822c655fa8faebd23f3f0fd756dab
Author: Greg Hudson <ghudson@mit.edu>
Date:   Tue Sep 24 01:47:18 2019 -0400

    Follow-up on krb5_gss_duplicate_name() null check
    
    Commit 9fd7bc179f0bd74fc83c1edf0247dcfd87fc73e6 missed a second null
    check, so the forward-null defect was not squashed.  Remove that one
    as well.

 src/lib/gssapi/krb5/duplicate_name.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/src/lib/gssapi/krb5/duplicate_name.c b/src/lib/gssapi/krb5/duplicate_name.c
index ea53e9c..670b2b5 100644
--- a/src/lib/gssapi/krb5/duplicate_name.c
+++ b/src/lib/gssapi/krb5/duplicate_name.c
@@ -38,8 +38,7 @@ krb5_gss_duplicate_name(OM_uint32 *minor_status, const gss_name_t input_name,
 
     code = krb5_gss_init_context(&context);
     if (code) {
-        if (minor_status)
-            *minor_status = code;
+        *minor_status = code;
         return GSS_S_FAILURE;
     }
 
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5

home help back first fref pref prev next nref lref last post