[30562] in CVS-changelog-for-Kerberos-V5
krb5 commit: Fix KCM client time offset propagation
daemon@ATHENA.MIT.EDU (Greg Hudson)
Thu Aug 15 13:38:18 2019
Date: Thu, 15 Aug 2019 13:38:10 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-ID: <201908151738.x7FHcA39017864@drugstore.mit.edu>
To: <cvs-krb5@mit.edu>
MIME-Version: 1.0
Reply-To: krbdev@mit.edu
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/323abb6d1ebe5469d6c2167c29aa5d696d099b90
commit 323abb6d1ebe5469d6c2167c29aa5d696d099b90
Author: Robbie Harwood <rharwood@redhat.com>
Date: Wed Aug 14 13:52:27 2019 -0400
Fix KCM client time offset propagation
An inverted status check in get_kdc_offset() would cause querying the
offset time from the ccache to always fail (silently) on KCM. Fix the
status check so that KCM can properly handle desync.
ticket: 8826 (new)
tags: pullup
target_version: 1.17-next
target_verison: 1.16-next
src/lib/krb5/ccache/cc_kcm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/lib/krb5/ccache/cc_kcm.c b/src/lib/krb5/ccache/cc_kcm.c
index 103cd98..1f5d6c8 100644
--- a/src/lib/krb5/ccache/cc_kcm.c
+++ b/src/lib/krb5/ccache/cc_kcm.c
@@ -577,7 +577,7 @@ get_kdc_offset(krb5_context context, krb5_ccache cache)
if (cache_call(context, cache, &req) != 0)
goto cleanup;
time_offset = k5_input_get_uint32_be(&req.reply);
- if (!req.reply.status)
+ if (req.reply.status)
goto cleanup;
context->os_context.time_offset = time_offset;
context->os_context.usec_offset = 0;
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
