[30239] in CVS-changelog-for-Kerberos-V5

home help back first fref pref prev next nref lref last post

krb5 commit: Fix minor leak in kdb5_util purge_mkeys

daemon@ATHENA.MIT.EDU (Greg Hudson)
Wed Jun 20 11:11:41 2018

Date: Wed, 20 Jun 2018 11:11:36 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201806201511.w5KFBax5022393@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu

https://github.com/krb5/krb5/commit/6d822841648761ac888b9a95693ad87a8aaf165c
commit 6d822841648761ac888b9a95693ad87a8aaf165c
Author: Greg Hudson <ghudson@mit.edu>
Date:   Tue Jun 19 13:03:05 2018 -0400

    Fix minor leak in kdb5_util purge_mkeys
    
    In kdb5_purge_mkeys(), if krb5_dbe_update_mkey_aux() fails, use the
    cleanup label to free any allocated memory instead of returning
    immediately.  Reported by Bean Zhang.
    
    ticket: 8702

 src/kadmin/dbutil/kdb5_mkey.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/kadmin/dbutil/kdb5_mkey.c b/src/kadmin/dbutil/kdb5_mkey.c
index 2efe317..5395a60 100644
--- a/src/kadmin/dbutil/kdb5_mkey.c
+++ b/src/kadmin/dbutil/kdb5_mkey.c
@@ -1297,7 +1297,7 @@ kdb5_purge_mkeys(int argc, char *argv[])
         com_err(progname, retval,
                 _("while updating mkey_aux data for master principal entry"));
         exit_status++;
-        return;
+        goto cleanup_return;
     }
 
     if ((retval = krb5_timeofday(util_context, &now))) {
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5

home help back first fref pref prev next nref lref last post