[30161] in CVS-changelog-for-Kerberos-V5
krb5 commit: Move zero argc check earlier in ksu
daemon@ATHENA.MIT.EDU (Greg Hudson)
Thu Apr 26 11:38:14 2018
Date: Thu, 26 Apr 2018 11:22:40 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201804261522.w3QFMeci004112@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/e1b5b824f5d7388a67d0854b56d3906c4fbdd778
commit e1b5b824f5d7388a67d0854b56d3906c4fbdd778
Author: Greg Hudson <ghudson@mit.edu>
Date: Tue Apr 24 19:35:38 2018 -0400
Move zero argc check earlier in ksu
For improved auditability, check for a zero argc value earlier in
main() so that the first two calls to com_err() can't pass a NULL
whoami value--which would be harmless, but that may not be obvious to
a reader.
ticket: 8661
src/clients/ksu/main.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/clients/ksu/main.c b/src/clients/ksu/main.c
index 5e79ef5..30f6db7 100644
--- a/src/clients/ksu/main.c
+++ b/src/clients/ksu/main.c
@@ -121,6 +121,9 @@ main (argc, argv)
krb5_boolean restrict_creds;
krb5_deltat lifetime, rlife;
+ if (argc == 0)
+ exit(1);
+
params = (char **) xcalloc (2, sizeof (char *));
params[1] = NULL;
@@ -138,8 +141,6 @@ main (argc, argv)
exit(1);
}
- if (argc == 0)
- exit(1);
if (strrchr(argv[0], '/'))
argv[0] = strrchr(argv[0], '/')+1;
prog_name = argv[0];
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
