[30149] in CVS-changelog-for-Kerberos-V5

home help back first fref pref prev next nref lref last post

krb5 commit: Fix small leak in wshelper DLL

daemon@ATHENA.MIT.EDU (Greg Hudson)
Mon Apr 9 19:46:32 2018

Date: Mon, 9 Apr 2018 19:46:20 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201804092346.w39NkKSM024139@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu

https://github.com/krb5/krb5/commit/0c013d6bc018d5be9f694ce80a27de740628133d
commit 0c013d6bc018d5be9f694ce80a27de740628133d
Author: Greg Hudson <ghudson@mit.edu>
Date:   Mon Apr 9 11:00:05 2018 -0400

    Fix small leak in wshelper DLL
    
    Remove a double initialization of dwHesPwUidIndex in wshelper which
    caused the first initialization to leak a thread-local storage handle.
    Reported by Sergey Ilinykh.
    
    ticket: 8663

 src/util/wshelper/dllmain.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/src/util/wshelper/dllmain.c b/src/util/wshelper/dllmain.c
index 5ae0016..d3706d2 100644
--- a/src/util/wshelper/dllmain.c
+++ b/src/util/wshelper/dllmain.c
@@ -43,8 +43,6 @@ DllMain(
             return FALSE;
 	if ((dwHesPwUidIndex = TlsAlloc()) == TLS_OUT_OF_INDEXES)
             return FALSE;
-	if ((dwHesPwUidIndex = TlsAlloc()) == TLS_OUT_OF_INDEXES)
-            return FALSE;
 	if ((dwGhnIndex = TlsAlloc()) == TLS_OUT_OF_INDEXES)
             return FALSE;
 	if ((dwGhaIndex = TlsAlloc()) == TLS_OUT_OF_INDEXES)
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5

home help back first fref pref prev next nref lref last post