[29619] in CVS-changelog-for-Kerberos-V5
krb5 commit [krb5-1.14]: Fix leak in ulog_replay()
daemon@ATHENA.MIT.EDU (Tom Yu)
Fri Sep 2 17:10:50 2016
Date: Fri, 2 Sep 2016 17:04:24 -0400
From: Tom Yu <tlyu@mit.edu>
Message-Id: <201609022104.u82L4O68023686@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/839c6b8edaf0fba65f833a0ec28f1c10b84a05ff
commit 839c6b8edaf0fba65f833a0ec28f1c10b84a05ff
Author: Greg Hudson <ghudson@mit.edu>
Date: Tue Jun 28 18:01:55 2016 -0400
Fix leak in ulog_replay()
ulog_conv_2dbentry() allocates a krb5_db_entry container; the caller
should not also do so.
(cherry picked from commit 2908839fcae0a12c56514d551ed1f19a7797cddb)
ticket: 8441
version_fixed: 1.14.4
src/lib/kdb/kdb_log.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/src/lib/kdb/kdb_log.c b/src/lib/kdb/kdb_log.c
index d377a20..99cda59 100644
--- a/src/lib/kdb/kdb_log.c
+++ b/src/lib/kdb/kdb_log.c
@@ -414,10 +414,6 @@ ulog_replay(krb5_context context, kdb_incr_result_t *incr_ret, char **db_args)
if (retval)
goto cleanup;
} else {
- entry = k5alloc(sizeof(krb5_db_entry), &retval);
- if (entry == NULL)
- goto cleanup;
-
retval = ulog_conv_2dbentry(context, &entry, upd);
if (retval)
goto cleanup;
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
