[29607] in CVS-changelog-for-Kerberos-V5

home help back first fref pref prev next nref lref last post

krb5 commit [krb5-1.14]: Fix leak in capaths processing

daemon@ATHENA.MIT.EDU (Tom Yu)
Fri Sep 2 17:04:32 2016

Date: Fri, 2 Sep 2016 17:04:28 -0400
From: Tom Yu <tlyu@mit.edu>
Message-Id: <201609022104.u82L4Se5023800@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu

https://github.com/krb5/krb5/commit/1cd322e9b6927a0eb2e102c4501eef0c94c4102f
commit 1cd322e9b6927a0eb2e102c4501eef0c94c4102f
Author: Greg Hudson <ghudson@mit.edu>
Date:   Wed Jun 29 00:01:04 2016 -0400

    Fix leak in capaths processing
    
    In k5_client_realm_path(), free the list of strings returned by
    rtree_capaths_vals().
    
    (cherry picked from commit 08756ce56bddab79afa4ee24b80243d8f822559d)
    
    ticket: 8447
    version_fixed: 1.14.4

 src/lib/krb5/krb/walk_rtree.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/lib/krb5/krb/walk_rtree.c b/src/lib/krb5/krb/walk_rtree.c
index 2b96628..0566a55 100644
--- a/src/lib/krb5/krb/walk_rtree.c
+++ b/src/lib/krb5/krb/walk_rtree.c
@@ -125,7 +125,7 @@ k5_client_realm_path(krb5_context context, const krb5_data *client,
                      const krb5_data *server, krb5_data **rpath_out)
 {
     krb5_error_code retval;
-    char **capvals;
+    char **capvals = NULL;
     size_t i;
     krb5_data *rpath = NULL, d;
 
@@ -160,6 +160,7 @@ k5_client_realm_path(krb5_context context, const krb5_data *client,
     rpath = NULL;
 
 cleanup:
+    profile_free_list(capvals);
     krb5int_free_data_list(context, rpath);
     return retval;
 }
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5

home help back first fref pref prev next nref lref last post