[29545] in CVS-changelog-for-Kerberos-V5

home help back first fref pref prev next nref lref last post

krb5 commit: Fix leak in ulog_replay()

daemon@ATHENA.MIT.EDU (Greg Hudson)
Wed Aug 10 13:53:58 2016

Date: Wed, 10 Aug 2016 13:51:39 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201608101751.u7AHpdT3009414@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu

https://github.com/krb5/krb5/commit/2908839fcae0a12c56514d551ed1f19a7797cddb
commit 2908839fcae0a12c56514d551ed1f19a7797cddb
Author: Greg Hudson <ghudson@mit.edu>
Date:   Tue Jun 28 18:01:55 2016 -0400

    Fix leak in ulog_replay()
    
    ulog_conv_2dbentry() allocates a krb5_db_entry container; the caller
    should not also do so.
    
    ticket: 8441 (new)
    target_version: 1.14-next
    target_version: 1.13-next
    tags: pullup

 src/lib/kdb/kdb_log.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/src/lib/kdb/kdb_log.c b/src/lib/kdb/kdb_log.c
index d377a20..99cda59 100644
--- a/src/lib/kdb/kdb_log.c
+++ b/src/lib/kdb/kdb_log.c
@@ -414,10 +414,6 @@ ulog_replay(krb5_context context, kdb_incr_result_t *incr_ret, char **db_args)
             if (retval)
                 goto cleanup;
         } else {
-            entry = k5alloc(sizeof(krb5_db_entry), &retval);
-            if (entry == NULL)
-                goto cleanup;
-
             retval = ulog_conv_2dbentry(context, &entry, upd);
             if (retval)
                 goto cleanup;
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5

home help back first fref pref prev next nref lref last post