[29543] in CVS-changelog-for-Kerberos-V5

home help back first fref pref prev next nref lref last post

krb5 commit: Fix leak in k5_free_cammac()

daemon@ATHENA.MIT.EDU (Greg Hudson)
Wed Aug 10 13:51:40 2016

Date: Wed, 10 Aug 2016 13:51:36 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201608101751.u7AHpa21009345@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu

https://github.com/krb5/krb5/commit/d9d6e7e9aa619d5bd35fa6e4468683ee7ddb5e5d
commit d9d6e7e9aa619d5bd35fa6e4468683ee7ddb5e5d
Author: Greg Hudson <ghudson@mit.edu>
Date:   Mon Jun 27 19:38:36 2016 -0400

    Fix leak in k5_free_cammac()
    
    free_vmac(), a helper function used by k5_free_cammac(), must free its
    val pointer as well as the contents; otherwise the krb5_verifier_mac
    container is leaked.
    
    ticket: 8438 (new)
    target_version: 1.14-next
    tags: pullup

 src/lib/krb5/krb/kfree.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/lib/krb5/krb/kfree.c b/src/lib/krb5/krb/kfree.c
index f857522..a631807 100644
--- a/src/lib/krb5/krb/kfree.c
+++ b/src/lib/krb5/krb/kfree.c
@@ -863,6 +863,7 @@ free_vmac(krb5_context context, krb5_verifier_mac *val)
         return;
     krb5_free_principal(context, val->princ);
     krb5_free_checksum_contents(context, &val->checksum);
+    free(val);
 }
 
 void
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5

home help back first fref pref prev next nref lref last post