[28735] in CVS-changelog-for-Kerberos-V5
krb5 commit [krb5-1.11]: Fix returning KDB_NOENTRY in
daemon@ATHENA.MIT.EDU (Tom Yu)
Fri Feb 6 17:33:13 2015
Date: Fri, 6 Feb 2015 17:26:55 -0500
From: Tom Yu <tlyu@mit.edu>
Message-Id: <201502062226.t16MQtSA024920@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/d91ca7782a2cd858333ce50273e600e58eeb773c
commit d91ca7782a2cd858333ce50273e600e58eeb773c
Author: Nalin Dahyabhai <nalin@dahyabhai.net>
Date: Thu Feb 20 16:01:49 2014 -0500
Fix returning KDB_NOENTRY in find_alternate_tgs()
After searching for a cross-realm TGS entry to provide to a client as a
referral, if we're all set to return a success code but aren't actually
returning an entry, we should be returning an error. We might not do so
because we don't compare the right value against NULL.
This corrects an error in a redundant check in the patch for
CVE-2013-1417. The error in the check cannot occur in practice
because the other part of the patch for CVE-2013-1417 prevents it, but
static analyzers can flag the erroneous check.
[tlyu@mit.edu: edit commit message]
(cherry picked from commit 90cbf4eb60d8ec3c083195ba4a050a31ea36be0b)
ticket: 8092 (new)
version_fixed: 1.11.6
status: resolved
src/kdc/do_tgs_req.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/kdc/do_tgs_req.c b/src/kdc/do_tgs_req.c
index e3fdce4..a90eeab 100644
--- a/src/kdc/do_tgs_req.c
+++ b/src/kdc/do_tgs_req.c
@@ -1063,7 +1063,7 @@ find_alternate_tgs(kdc_realm_t *kdc_active_realm, krb5_principal princ,
goto cleanup;
}
cleanup:
- if (retval == 0 && server_ptr == NULL)
+ if (retval == 0 && *server_ptr == NULL)
retval = KRB5_KDB_NOENTRY;
if (retval != 0)
*status = "UNKNOWN_SERVER";
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
