[28406] in CVS-changelog-for-Kerberos-V5
krb5 commit [krb5-1.12]: Initialize err variable in krb5_sendto_kdc
daemon@ATHENA.MIT.EDU (Tom Yu)
Thu Jun 26 16:54:01 2014
Date: Thu, 26 Jun 2014 16:53:39 -0400
From: Tom Yu <tlyu@mit.edu>
Message-Id: <201406262053.s5QKrdHM031603@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/8c91982b52c087b4335f1dada6810ae7bfbe3644
commit 8c91982b52c087b4335f1dada6810ae7bfbe3644
Author: Nalin Dahyabhai <nalin@dahyabhai.net>
Date: Tue Mar 11 13:26:32 2014 -0400
Initialize err variable in krb5_sendto_kdc
When we get an KRB5_KDC_UNREACH error back from k5_sendto, we check if
the err variable we passed for use by our message handler has been set
to KDC_ERR_SVC_UNAVAILABLE. If k5_sendto doesn't receive any
response, though, the handler isn't called, so we're reading an
uninitialized variable. Initialize it to a value other than
KDC_ERR_SVC_UNAVAILABLE to be sure.
[ghudson@mit.edu: initialize err just before calling k5_sendto; edit
commit message]
(cherry picked from commit 1ed3f68c2394fbb48731bba4e4e9a60c8b925ca5)
ticket: 7874
version_fixed: 1.12.2
status: resolved
src/lib/krb5/os/sendto_kdc.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/lib/krb5/os/sendto_kdc.c b/src/lib/krb5/os/sendto_kdc.c
index e0f360a..1de513a 100644
--- a/src/lib/krb5/os/sendto_kdc.c
+++ b/src/lib/krb5/os/sendto_kdc.c
@@ -214,6 +214,7 @@ krb5_sendto_kdc(krb5_context context, const krb5_data *message,
if (retval)
return retval;
+ err = 0;
retval = k5_sendto(context, message, &servers, socktype1, socktype2,
NULL, reply, NULL, NULL, &server_used,
check_for_svc_unavailable, &err);
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
