[28284] in CVS-changelog-for-Kerberos-V5

home help back first fref pref prev next nref lref last post

krb5 commit: Don't leak the per-request preauth context

daemon@ATHENA.MIT.EDU (Greg Hudson)
Thu Mar 13 15:47:41 2014

Date: Thu, 13 Mar 2014 15:47:36 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201403131947.s2DJlavD029226@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu

https://github.com/krb5/krb5/commit/a47c4e68308331a630480cb62c2b7711432e0123
commit a47c4e68308331a630480cb62c2b7711432e0123
Author: Nalin Dahyabhai <nalin@dahyabhai.net>
Date:   Tue Mar 11 13:33:23 2014 -0400

    Don't leak the per-request preauth context
    
    Currently, per-request preauth module data is only cleared when we
    successfully obtain initial credentials.  Make sure to clear it at the
    end of the operation even if we failed to get creds.
    
    [ghudson@mit.edu: expanded commit message]
    
    ticket: 7793
    target_version: 1.12.2
    tags: pullup

 src/lib/krb5/krb/get_in_tkt.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/lib/krb5/krb/get_in_tkt.c b/src/lib/krb5/krb/get_in_tkt.c
index ebd2844..ebcb362 100644
--- a/src/lib/krb5/krb/get_in_tkt.c
+++ b/src/lib/krb5/krb/get_in_tkt.c
@@ -488,6 +488,7 @@ krb5_init_creds_free(krb5_context context,
     k5_response_items_free(ctx->rctx.items);
     free(ctx->in_tkt_service);
     zapfree(ctx->gakpw.storage.data, ctx->gakpw.storage.length);
+    k5_preauth_request_context_fini(context);
     krb5_free_error(context, ctx->err_reply);
     krb5_free_pa_data(context, ctx->err_padata);
     krb5_free_cred_contents(context, &ctx->cred);
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5

home help back first fref pref prev next nref lref last post