[28219] in CVS-changelog-for-Kerberos-V5
krb5 commit [krb5-1.10]: Fix memory leak in SPNEGO initiator
daemon@ATHENA.MIT.EDU (Tom Yu)
Wed Jan 22 22:38:05 2014
Date: Wed, 22 Jan 2014 22:37:59 -0500
From: Tom Yu <tlyu@mit.edu>
Message-Id: <201401230337.s0N3bxZW031029@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/38ad045d2b0c3418b10cd9f252f61aac2d54c1c7
commit 38ad045d2b0c3418b10cd9f252f61aac2d54c1c7
Author: Simo Sorce <simo@redhat.com>
Date: Fri Dec 13 12:00:41 2013 -0500
Fix memory leak in SPNEGO initiator
If we eliminate a mechanism from the initiator list because
gss_init_sec_context fails, free the memory for that mech OID before
removing it from the list.
[ghudson@mit.edu: clarified commit message]
(cherry picked from commit 1cda48a7ed4069cfc052f974ec3d76a9137c8c5a)
ticket: 7843 (new)
version_fixed: 1.10.8
status: resolved
src/lib/gssapi/spnego/spnego_mech.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/lib/gssapi/spnego/spnego_mech.c b/src/lib/gssapi/spnego/spnego_mech.c
index f26db63..4f8e13d 100644
--- a/src/lib/gssapi/spnego/spnego_mech.c
+++ b/src/lib/gssapi/spnego/spnego_mech.c
@@ -886,6 +886,7 @@ init_ctx_call_init(OM_uint32 *minor_status,
* can do this with recursion. If all mechanisms produce errors, the
* caller should get the error from the first mech in the list.
*/
+ gssalloc_free(sc->mech_set->elements->elements);
memmove(sc->mech_set->elements, sc->mech_set->elements + 1,
--sc->mech_set->count * sizeof(*sc->mech_set->elements));
if (sc->mech_set->count == 0)
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
