[28204] in CVS-changelog-for-Kerberos-V5

home help back first fref pref prev next nref lref last post

krb5 commit: Clean up rcache if GSS krb5 acquire_cred fails

daemon@ATHENA.MIT.EDU (Greg Hudson)
Fri Jan 17 15:59:06 2014

Date: Fri, 17 Jan 2014 15:58:53 -0500
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201401172058.s0HKwrOh025430@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu

https://github.com/krb5/krb5/commit/9df0c4bdce6b88a01af51e4bbb9a365db00256d5
commit 9df0c4bdce6b88a01af51e4bbb9a365db00256d5
Author: Greg Hudson <ghudson@mit.edu>
Date:   Wed Jan 15 14:41:54 2014 -0500

    Clean up rcache if GSS krb5 acquire_cred fails
    
    The error handler in acquire_cred_context didn't release the rcache,
    which would cause it to leak if we failed after acquire_accept_cred.
    
    ticket: 7818 (new)
    target_version: 1.12.2
    tags: pullup

 src/lib/gssapi/krb5/acquire_cred.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/lib/gssapi/krb5/acquire_cred.c b/src/lib/gssapi/krb5/acquire_cred.c
index 37cc6b5..f625c0c 100644
--- a/src/lib/gssapi/krb5/acquire_cred.c
+++ b/src/lib/gssapi/krb5/acquire_cred.c
@@ -829,6 +829,8 @@ error_out:
         if (cred->keytab)
             krb5_kt_close(context, cred->keytab);
 #endif /* LEAN_CLIENT */
+        if (cred->rcache)
+            krb5_rc_close(context, cred->rcache);
         if (cred->name)
             kg_release_name(context, &cred->name);
         k5_mutex_destroy(&cred->lock);
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5

home help back first fref pref prev next nref lref last post