[27846] in CVS-changelog-for-Kerberos-V5
krb5 commit: Don't leak the reply key's memory during PKINIT
daemon@ATHENA.MIT.EDU (Greg Hudson)
Mon Jul 15 11:02:31 2013
Date: Mon, 15 Jul 2013 11:02:25 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201307151502.r6FF2PSQ019899@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/40d61fe580a57d63987c4e2b8eecd9f0ed1f1189
commit 40d61fe580a57d63987c4e2b8eecd9f0ed1f1189
Author: Nalin Dahyabhai <nalin@dahyabhai.net>
Date: Tue Jul 9 17:20:27 2013 -0400
Don't leak the reply key's memory during PKINIT
src/plugins/preauth/pkinit/pkinit_clnt.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/plugins/preauth/pkinit/pkinit_clnt.c b/src/plugins/preauth/pkinit/pkinit_clnt.c
index ff564ff..5db24da 100644
--- a/src/plugins/preauth/pkinit/pkinit_clnt.c
+++ b/src/plugins/preauth/pkinit/pkinit_clnt.c
@@ -1130,8 +1130,10 @@ pkinit_client_process(krb5_context context, krb5_clpreauth_moddata moddata,
retval = pa_pkinit_parse_rep(context, plgctx, reqctx, request,
in_padata, enctype, &as_key,
encoded_previous_request);
- if (retval == 0)
+ if (retval == 0) {
retval = cb->set_as_key(context, rock, &as_key);
+ krb5_free_keyblock_contents(context, &as_key);
+ }
}
pkiDebug("pkinit_client_process: returning %d (%s)\n",
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
