[27735] in CVS-changelog-for-Kerberos-V5

home help back first fref pref prev next nref lref last post

krb5 commit: Don't send empty etype info from KDC

daemon@ATHENA.MIT.EDU (Greg Hudson)
Fri May 3 16:16:27 2013

Date: Fri, 3 May 2013 16:16:19 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201305032016.r43KGJ9H003469@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu

https://github.com/krb5/krb5/commit/ef700ee2cc1b33a06cd1e5c6c56ca7cfac8e67c5
commit ef700ee2cc1b33a06cd1e5c6c56ca7cfac8e67c5
Author: Greg Hudson <ghudson@mit.edu>
Date:   Mon Apr 29 14:55:31 2013 -0400

    Don't send empty etype info from KDC
    
    RFC 4120 prohibits empty ETYPE-INFO2 sequences (though not ETYPE-INFO
    sequences), and our client errors out if it sees an empty sequence of
    either.
    
    ticket: 7630

 src/kdc/kdc_preauth.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/src/kdc/kdc_preauth.c b/src/kdc/kdc_preauth.c
index b7f9e15..9c04f70 100644
--- a/src/kdc/kdc_preauth.c
+++ b/src/kdc/kdc_preauth.c
@@ -1420,6 +1420,11 @@ etype_info_helper(krb5_context context, krb5_kdc_req *request,
             seen_des++;
         }
     }
+
+    /* If the list is empty, don't send it at all. */
+    if (i == 0)
+        goto cleanup;
+
     if (etype_info2)
         retval = encode_krb5_etype_info2(entry, &scratch);
     else
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5

home help back first fref pref prev next nref lref last post