[27614] in CVS-changelog-for-Kerberos-V5
krb5 commit: Fix use-before-init in two test programs
daemon@ATHENA.MIT.EDU (Greg Hudson)
Fri Mar 15 02:32:19 2013
Date: Fri, 15 Mar 2013 02:32:14 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201303150632.r2F6WEQS015240@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/525eafc83a0fbe8f215b7749b5774d54468a19d1
commit 525eafc83a0fbe8f215b7749b5774d54468a19d1
Author: Greg Hudson <ghudson@mit.edu>
Date: Fri Mar 15 01:57:40 2013 -0400
Fix use-before-init in two test programs
If krb5_init_context fails, use a null context for getting the error
message, not a context we haven't yet initialized. Observed by David
Benjamin <davidben@mit.edu> using clang.
src/lib/krb5/krb/t_cc_config.c | 2 +-
src/lib/krb5/krb/t_in_ccache.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib/krb5/krb/t_cc_config.c b/src/lib/krb5/krb/t_cc_config.c
index 3750a59..04e7283 100644
--- a/src/lib/krb5/krb/t_cc_config.c
+++ b/src/lib/krb5/krb/t_cc_config.c
@@ -117,7 +117,7 @@ main(int argc, char **argv)
int c;
unsigned int i;
- bail_on_err(context, "Error initializing Kerberos library",
+ bail_on_err(NULL, "Error initializing Kerberos library",
krb5_init_context(&context));
bail_on_err(context, "Error getting location of default ccache",
krb5_cc_default(context, &ccache));
diff --git a/src/lib/krb5/krb/t_in_ccache.c b/src/lib/krb5/krb/t_in_ccache.c
index c73a043..30b7f28 100644
--- a/src/lib/krb5/krb/t_in_ccache.c
+++ b/src/lib/krb5/krb/t_in_ccache.c
@@ -95,7 +95,7 @@ main(int argc, char **argv)
user = argv[optind];
password = argv[optind + 1];
- bail_on_err(ctx, "Error initializing Kerberos", krb5_init_context(&ctx));
+ bail_on_err(NULL, "Error initializing Kerberos", krb5_init_context(&ctx));
bail_on_err(ctx, "Error allocating space for get_init_creds options",
krb5_get_init_creds_opt_alloc(ctx, &opt));
if (in_ccname != NULL) {
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
