[27453] in CVS-changelog-for-Kerberos-V5
krb5 commit: Initialize ret in process_pa_data
daemon@ATHENA.MIT.EDU (Greg Hudson)
Fri Dec 21 16:21:14 2012
Date: Fri, 21 Dec 2012 16:21:12 -0500
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201212212121.qBLLLC8i027456@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/90e43628202157d72fb78bbb837795d91d5ce8da
commit 90e43628202157d72fb78bbb837795d91d5ce8da
Author: Greg Hudson <ghudson@mit.edu>
Date: Fri Dec 21 16:18:34 2012 -0500
Initialize ret in process_pa_data
If the for loop never consults any preauth modules and must_preauth is
false, we might never set ret, so we need to initialize it. The bug
was introduced in 5c23bce0e8d3328bb36bc85ee10cfac486b8ae9b and is
detected by some versions of gcc with -O2.
src/lib/krb5/krb/preauth2.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/lib/krb5/krb/preauth2.c b/src/lib/krb5/krb/preauth2.c
index a06233c..8d5439c 100644
--- a/src/lib/krb5/krb/preauth2.c
+++ b/src/lib/krb5/krb/preauth2.c
@@ -586,7 +586,7 @@ process_pa_data(krb5_context context, krb5_get_init_creds_opt *opt,
struct krb5_preauth_context_st *pctx = context->preauth_context;
struct errinfo save = EMPTY_ERRINFO;
krb5_pa_data *pa, **pa_ptr, **mod_pa;
- krb5_error_code ret;
+ krb5_error_code ret = 0;
clpreauth_handle h;
int real, i;
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
