[27395] in CVS-changelog-for-Kerberos-V5

home help back first fref pref prev next nref lref last post

krb5 commit: Use an empty challenge for the password question

daemon@ATHENA.MIT.EDU (Greg Hudson)
Thu Dec 13 14:54:16 2012

Date: Thu, 13 Dec 2012 14:54:14 -0500
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201212131954.qBDJsECC031833@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu

https://github.com/krb5/krb5/commit/70f2d9a093c71624269b2317c62ad0993126bc40
commit 70f2d9a093c71624269b2317c62ad0993126bc40
Author: Greg Hudson <ghudson@mit.edu>
Date:   Thu Dec 13 14:53:58 2012 -0500

    Use an empty challenge for the password question
    
    If a question's challenge is NULL, it is unnecessarily difficult for a
    responder callback to detect whether it was asked.  So it's better to
    use an empty challenge when there is no challenge data to communicate.
    Do this for the "password" question.
    
    ticket: 7499 (new)
    target_version: 1.11
    tags: pullup

 src/lib/krb5/krb/gic_pwd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/lib/krb5/krb/gic_pwd.c b/src/lib/krb5/krb/gic_pwd.c
index 8ffa342..30da8c9 100644
--- a/src/lib/krb5/krb/gic_pwd.c
+++ b/src/lib/krb5/krb/gic_pwd.c
@@ -36,7 +36,7 @@ krb5_get_as_key_password(krb5_context context,
 
         return k5_response_items_ask_question(ritems,
                                               KRB5_RESPONDER_QUESTION_PASSWORD,
-                                              NULL );
+                                              "");
     }
 
     /* If there's already a key of the correct etype, we're done.
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5

home help back first fref pref prev next nref lref last post