[27312] in CVS-changelog-for-Kerberos-V5

home help back first fref pref prev next nref lref last post

krb5 commit: Fix spin-loop bug in k5_sendto_kdc

daemon@ATHENA.MIT.EDU (Greg Hudson)
Thu Nov 29 02:00:30 2012

Date: Thu, 29 Nov 2012 01:59:40 -0500
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201211290659.qAT6xeXX028611@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu

https://github.com/krb5/krb5/commit/2b06a22f7fd8ec01fb27a7335125290b8ceb6f18
commit 2b06a22f7fd8ec01fb27a7335125290b8ceb6f18
Author: Greg Hudson <ghudson@mit.edu>
Date:   Thu Nov 29 01:58:13 2012 -0500

    Fix spin-loop bug in k5_sendto_kdc
    
    In the second part of the first pass over the server list, we passed
    the wrong list pointer to service_fds, causing it to see only a subset
    of the server entries corresponding to sel_state.  This could cause
    service_fds to spin if an event is reported on an fd not in the
    subset.
    
    ticket: 7454
    target_version: 1.10.4
    tags: pullup

 src/lib/krb5/os/sendto_kdc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/lib/krb5/os/sendto_kdc.c b/src/lib/krb5/os/sendto_kdc.c
index 63dbcd8..22cd908 100644
--- a/src/lib/krb5/os/sendto_kdc.c
+++ b/src/lib/krb5/os/sendto_kdc.c
@@ -1287,7 +1287,7 @@ k5_sendto(krb5_context context, const krb5_data *message,
             continue;
         if (maybe_send(context, state, sel_state, callback_info))
             continue;
-        done = service_fds(context, sel_state, 1, state, seltemp, msg_handler,
+        done = service_fds(context, sel_state, 1, conns, seltemp, msg_handler,
                            msg_handler_data, &winner);
     }
 
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5

home help back first fref pref prev next nref lref last post