[26947] in CVS-changelog-for-Kerberos-V5
krb5 commit: Avoid a crash when attempting to change password
daemon@ATHENA.MIT.EDU (Benjamin Kaduk)
Wed Aug 29 16:34:55 2012
Date: Wed, 29 Aug 2012 16:34:52 -0400
From: Benjamin Kaduk <kaduk@mit.edu>
Message-Id: <201208292034.q7TKYq5x000481@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/023aac4a5d682ffeacc5121deaa771e08a5c9013
commit 023aac4a5d682ffeacc5121deaa771e08a5c9013
Author: Benjamin Kaduk <kaduk@mit.edu>
Date: Tue Jul 31 16:12:27 2012 -0400
Avoid a crash when attempting to change password
In some cases we could keep stack garbage in a local pointer
variable until the cleanup at the end of the function wherein
krb5_free_context() would choke on the invalid non-NULL value.
Initialize to zero to avoid the issue (should be written as NULL
but stick to the prevailing style).
ticket: 7329 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
src/windows/leash/LeashView.cpp | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/windows/leash/LeashView.cpp b/src/windows/leash/LeashView.cpp
index eedc5a2..51777e4 100644
--- a/src/windows/leash/LeashView.cpp
+++ b/src/windows/leash/LeashView.cpp
@@ -1034,7 +1034,7 @@ VOID CLeashView::OnMakeDefault()
VOID CLeashView::OnChangePassword()
{
- krb5_context ctx;
+ krb5_context ctx = 0;
krb5_ccache ccache = 0;
krb5_principal princ = 0;
char *pname = NULL;
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
