[26678] in CVS-changelog-for-Kerberos-V5
krb5 commit: Avoid unsigned/signed comparison in loop condition
daemon@ATHENA.MIT.EDU (Benjamin Kaduk)
Tue Jul 3 11:08:45 2012
Date: Tue, 3 Jul 2012 00:43:52 -0400
From: Benjamin Kaduk <kaduk@mit.edu>
Message-Id: <201207030443.q634hqRG013661@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/f59478241686d75ece48e8eff6099006cf0bb1b2
commit f59478241686d75ece48e8eff6099006cf0bb1b2
Author: Ben Kaduk <kaduk@mit.edu>
Date: Wed Jun 27 15:38:47 2012 -0400
Avoid unsigned/signed comparison in loop condition
The gid_len length is declared as an unsigned int, and loop
index 'i' is a signed int. This could manifest as an infinite
loop if gid_len is very large. In practice, gid_len should be small,
but make 'i' the same type for consistency.
src/lib/rpc/svc_auth_unix.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/src/lib/rpc/svc_auth_unix.c b/src/lib/rpc/svc_auth_unix.c
index 406abf7..a4b87d8 100644
--- a/src/lib/rpc/svc_auth_unix.c
+++ b/src/lib/rpc/svc_auth_unix.c
@@ -66,8 +66,7 @@ gssrpc__svcauth_unix(
char area_machname[MAX_MACHINE_NAME+1];
int area_gids[NGRPS];
} *area;
- u_int auth_len, str_len, gid_len;
- register int i;
+ u_int auth_len, str_len, gid_len, i;
rqst->rq_xprt->xp_auth = &svc_auth_none;
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
