[26674] in CVS-changelog-for-Kerberos-V5
krb5 commit: Use consistent types for overflow comparison
daemon@ATHENA.MIT.EDU (Benjamin Kaduk)
Tue Jul 3 11:08:42 2012
Date: Tue, 3 Jul 2012 00:43:52 -0400
From: Benjamin Kaduk <kaduk@mit.edu>
Message-Id: <201207030443.q634hqel013678@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
https://github.com/krb5/krb5/commit/e7aa25d215a9d4baa95643f2d19e44036e57af72
commit e7aa25d215a9d4baa95643f2d19e44036e57af72
Author: Ben Kaduk <kaduk@mit.edu>
Date: Wed Jun 27 16:00:16 2012 -0400
Use consistent types for overflow comparison
Unsigned long might not be 32-bits, in which case the overflow check
fails for a 32-bit kdb_sno_t. Cast from -1 explicitly as a more
robust check.
src/lib/kdb/kdb_log.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/lib/kdb/kdb_log.c b/src/lib/kdb/kdb_log.c
index 625c71a..0153375 100644
--- a/src/lib/kdb/kdb_log.c
+++ b/src/lib/kdb/kdb_log.c
@@ -204,7 +204,7 @@ ulog_add_update(krb5_context context, kdb_incr_update_t *upd)
* We need to overflow our sno, replicas will do full
* resyncs once they see their sno > than the masters.
*/
- if (cur_sno == ULONG_MAX)
+ if (cur_sno == (kdb_sno_t)-1)
cur_sno = 1;
else
cur_sno++;
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
