[26666] in CVS-changelog-for-Kerberos-V5

home help back first fref pref prev next nref lref last post

krb5 commit: Fix minor memory leaks in acquire_cred.c

daemon@ATHENA.MIT.EDU (Greg Hudson)
Mon Jul 2 14:13:50 2012

Date: Mon, 2 Jul 2012 14:13:47 -0400
From: Greg Hudson <ghudson@mit.edu>
Message-Id: <201207021813.q62IDlXs013794@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu

https://github.com/krb5/krb5/commit/76e5a44413c6bdb061263ed7d33ff7b494fa485a
commit 76e5a44413c6bdb061263ed7d33ff7b494fa485a
Author: Greg Hudson <ghudson@mit.edu>
Date:   Mon Jul 2 13:21:04 2012 -0400

    Fix minor memory leaks in acquire_cred.c

 src/lib/gssapi/krb5/acquire_cred.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/lib/gssapi/krb5/acquire_cred.c b/src/lib/gssapi/krb5/acquire_cred.c
index 1972b1e..0527d13 100644
--- a/src/lib/gssapi/krb5/acquire_cred.c
+++ b/src/lib/gssapi/krb5/acquire_cred.c
@@ -774,10 +774,8 @@ acquire_cred(OM_uint32 *minor_status, gss_name_t desired_name,
 
     if (name != NULL) {
         code = kg_duplicate_name(context, name, &cred->name);
-        if (code) {
-            *minor_status = code;
-            return GSS_S_FAILURE;
-        }
+        if (code)
+            goto krb_error_out;
     }
 
 #ifndef LEAN_CLIENT
@@ -834,6 +832,8 @@ error_out:
     if (cred != NULL) {
         if (cred->ccache)
             krb5_cc_close(context, cred->ccache);
+        if (cred->client_keytab)
+            krb5_kt_close(context, cred->client_keytab);
 #ifndef LEAN_CLIENT
         if (cred->keytab)
             krb5_kt_close(context, cred->keytab);
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5

home help back first fref pref prev next nref lref last post