[26502] in CVS-changelog-for-Kerberos-V5
svn rev #25833: trunk/src/lib/krb5/krb/
daemon@ATHENA.MIT.EDU (ghudson@mit.edu)
Fri Apr 27 13:04:27 2012
Date: Fri, 27 Apr 2012 13:04:24 -0400
From: ghudson@mit.edu
Message-Id: <201204271704.q3RH4OU4014869@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu
http://src.mit.edu/fisheye/changelog/krb5/?cs=25833
Commit By: ghudson
Log Message:
Ensure null termination of AFS salts
Use krb5int_copy_data_contents_add0 when copying a pa-pw-salt or
pa-afs3-salt value in pa_salt(). If it's an afs3-salt, we're going to
throw away the length and use strcspn in krb5int_des_string_to_key,
which isn't safe if the value is unterminated.
ticket: 2545
Changed Files:
U trunk/src/lib/krb5/krb/preauth2.c
Modified: trunk/src/lib/krb5/krb/preauth2.c
===================================================================
--- trunk/src/lib/krb5/krb/preauth2.c 2012-04-26 21:47:05 UTC (rev 25832)
+++ trunk/src/lib/krb5/krb/preauth2.c 2012-04-27 17:04:24 UTC (rev 25833)
@@ -565,7 +565,7 @@
tmp = padata2data(*in_padata);
krb5_free_data_contents(context, salt);
- retval = krb5int_copy_data_contents(context, &tmp, salt);
+ retval = krb5int_copy_data_contents_add0(context, &tmp, salt);
if (retval)
return retval;
_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5
