[26328] in CVS-changelog-for-Kerberos-V5

home help back first fref pref prev next nref lref last post

svn rev #3330: trunk/gssftp/ftp/

daemon@ATHENA.MIT.EDU (ghudson@mit.edu)
Fri Jan 27 15:41:48 2012

Date: Fri, 27 Jan 2012 15:41:47 -0500
From: ghudson@mit.edu
Message-Id: <201201272041.q0RKflc8022509@drugstore.mit.edu>
To: krb5-appl-commits@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: krb5-appl-commits-bounces@mit.edu

Commit By: ghudson
Log Message:
ticket: 7079

Ensure termination of file mode in gssftps' mls

Depending on stack contents, mls or mdir could sporadically fail due
to an unterminated file mode argument.  Patch from Siddhesh Poyarekar
via nalin@redhat.com.



Changed Files:
U   trunk/gssftp/ftp/cmds.c
Modified: trunk/gssftp/ftp/cmds.c
===================================================================
--- trunk/gssftp/ftp/cmds.c	2011-12-27 17:14:35 UTC (rev 3329)
+++ trunk/gssftp/ftp/cmds.c	2012-01-27 20:41:46 UTC (rev 3330)
@@ -1479,7 +1479,7 @@
 {
 	sig_t oldintr;
 	int ointer, i;
-	char *volatile cmd, rmode[1], *dest;
+	char *volatile cmd, rmode[2], *dest;
 
 	if (argc < 2 && !another(&argc, &argv, "remote-files"))
 		goto usage;
@@ -1503,7 +1503,8 @@
 	oldintr = signal(SIGINT, mabort);
 	(void) setjmp(jabort);
 	for (i = 1; mflag && i < argc-1; ++i) {
-		*rmode = (i == 1) ? 'w' : 'a';
+		rmode[0] = (i == 1) ? 'w' : 'a';
+		rmode[1] = 0;
 		recvrequest(cmd, dest, argv[i], rmode, 0, 0);
 		if (!mflag && fromatty) {
 			ointer = interactive;

_______________________________________________
Krb5-appl-commits mailing list
Krb5-appl-commits@mit.edu
http://mailman.mit.edu/mailman/listinfo/krb5-appl-commits

home help back first fref pref prev next nref lref last post