[26158] in CVS-changelog-for-Kerberos-V5

home help back first fref pref prev next nref lref last post

svn rev #25498: trunk/src/lib/krb5/os/

daemon@ATHENA.MIT.EDU (hartmans@mit.edu)
Fri Dec 2 13:52:30 2011

Date: Fri, 2 Dec 2011 13:52:22 -0500
From: hartmans@mit.edu
Message-Id: <201112021852.pB2IqMq2001173@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu

http://src.mit.edu/fisheye/changelog/krb5/?cs=25498
Commit By: hartmans
Log Message:
ticket: 7036
subject: Fix free ofuninitialized memory in sname_to_princ
tags: pullup
Target_Version: 1.10

Fix free of uninitialized memory in error case introduced in 1.10
development cycle.


Changed Files:
U   trunk/src/lib/krb5/os/sn2princ.c
Modified: trunk/src/lib/krb5/os/sn2princ.c
===================================================================
--- trunk/src/lib/krb5/os/sn2princ.c	2011-12-02 18:52:19 UTC (rev 25497)
+++ trunk/src/lib/krb5/os/sn2princ.c	2011-12-02 18:52:22 UTC (rev 25498)
@@ -90,7 +90,7 @@
         /* copy the hostname into non-volatile storage */
 
         if (type == KRB5_NT_SRV_HST) {
-            struct addrinfo *ai, hints;
+            struct addrinfo *ai = NULL, hints;
             int err;
             char hnamebuf[NI_MAXHOST];
 
@@ -114,7 +114,8 @@
             }
             remote_host = strdup((ai && ai->ai_canonname) ? ai->ai_canonname : hostname);
             if (!remote_host) {
-                freeaddrinfo(ai);
+                if(ai)
+                    freeaddrinfo(ai);
                 return ENOMEM;
             }
 

_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5

home help back first fref pref prev next nref lref last post