[25749] in CVS-changelog-for-Kerberos-V5

home help back first fref pref prev next nref lref last post

svn rev #25239: trunk/src/lib/krb5/krb/

daemon@ATHENA.MIT.EDU (ghudson@mit.edu)
Tue Sep 27 11:05:47 2011

Date: Tue, 27 Sep 2011 11:05:44 -0400
From: ghudson@mit.edu
Message-Id: <201109271505.p8RF5ixc013904@drugstore.mit.edu>
To: cvs-krb5@mit.edu
Reply-To: krbdev@mit.edu
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cvs-krb5-bounces@mit.edu

http://src.mit.edu/fisheye/changelog/krb5/?cs=25239
Commit By: ghudson
Log Message:
Fix an error case in encrypted timestamp preauth.

If krb5_encrypt_helper returns an error, it's not the caller's
responsibility to free enc_data.ciphertext, and in one case (if
krb5_c_encrypt_length returns an error) it won't have been
initialized.


Changed Files:
U   trunk/src/lib/krb5/krb/preauth2.c
Modified: trunk/src/lib/krb5/krb/preauth2.c
===================================================================
--- trunk/src/lib/krb5/krb/preauth2.c	2011-09-26 20:23:15 UTC (rev 25238)
+++ trunk/src/lib/krb5/krb/preauth2.c	2011-09-27 15:05:44 UTC (rev 25239)
@@ -678,10 +678,8 @@
 
     krb5_free_data(context, tmp);
 
-    if (ret) {
-        free(enc_data.ciphertext.data);
+    if (ret)
         return(ret);
-    }
 
     ret = encode_krb5_enc_data(&enc_data, &tmp);
 

_______________________________________________
cvs-krb5 mailing list
cvs-krb5@mit.edu
https://mailman.mit.edu/mailman/listinfo/cvs-krb5

home help back first fref pref prev next nref lref last post