[6324] in bugtraq

home help back first fref pref prev next nref lref last post

Re: Midnight Commander /tmp race

daemon@ATHENA.MIT.EDU (Pavel Kankovsky)
Tue Mar 17 17:52:25 1998

Date: 	Tue, 17 Mar 1998 18:21:09 +0100
Reply-To: peak@kerberos.troja.mff.cuni.cz
From: Pavel Kankovsky <peak@KERBEROS.TROJA.MFF.CUNI.CZ>
X-To:         Michal Zalewski <lcamtuf@BOSS.STASZIC.WAW.PL>
To: BUGTRAQ@NETSPACE.ORG
In-Reply-To:  <Pine.LNX.3.96.980315162318.8796A-100000@genome>

On Sun, 15 Mar 1998, Michal Zalewski wrote:

> Midnight Commander (I have version 4.1.8, RedHat 5.0) is launched using
> the following shell macro:
>
> mc=()
> {
>     MC=/tmp/mc$$-"$RANDOM";
>     /usr/bin/mc -P "$@" >"$MC";
>     cd "`cat $MC`";
>     rm "$MC";
>     unset MC
> }
>
> Solution? Use mktemp: MC=`mktemp mc$$-XXXXXX` instead of $RANDOM :)))

Solution? Don't use any temporary file at all.

mc()
{
        MC=`/usr/bin/mc -P "$@"`
        [ -n "$MC" ] && cd $MC
        unset MC
}

The function is from mcfn_install script. The alias in lib/mc.csh is
similar. But lib/mc.sh is the aformentioned lame one. It's absurd.

--Pavel Kankovsky aka Peak   [ Boycott Microsoft -- http://www.vcnet.com/bms ]

home help back first fref pref prev next nref lref last post