[34701] in bugtraq
Re: phpBB 2.0.8a and lower - IP spoofing vulnerability
daemon@ATHENA.MIT.EDU (BlueRaven)
Wed Apr 28 20:19:14 2004
Date: Wed, 28 Apr 2004 11:03:26 +0200
From: BlueRaven <blue@ravenconsulting.it>
To: bugtraq@securityfocus.com
Message-ID: <20040428090326.GA4886@mythdrannor.my.lan>
Mail-Followup-To: bugtraq@securityfocus.com
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040421011055.GA1448@frontfree.net>
On Wed, Apr 21, 2004 at 09:10:55AM +0800, Xin LI wrote:
Hi Xin, I think there's an error in your patch:
> - if ( !$db->sql_query($sql) )
> + if ( $user_id != ANONYMOUS && !$db->sql_query($sql) )
This does NOT prevent execution of the query, only effects output of the
message:
> {
> message_die(CRITICAL_ERROR, 'Error creating new session', '', __LINE__, __FILE__, $sql);
> }
I think it should read as follows:
if ( $user_id != ANONYMOUS ) {
if ( !$db->sql_query($sql) {
message_die(CRITICAL_ERROR, 'Error creating new session', '', __LINE__, __FILE__, $sql);
}
}
I'm not great PHP programmer, though, so please correct me if I'm wrong.
Cheers! :-)
--
#include <best/regards.h>
BlueRaven
Did you know that if you play a Windows 2000 CD backwards, you will hear
the voice of Satan? That's nothing!
If you play it forward, it'll install Windows 2000.
