[34436] in bugtraq
Re: GNU Sharutils buffer overflow vulnerability.
daemon@ATHENA.MIT.EDU (=?iso-8859-1?q?Didier=20Arenzana?=)
Wed Apr 7 16:50:43 2004
Message-ID: <20040407080301.79440.qmail@web14205.mail.yahoo.com>
Date: Wed, 7 Apr 2004 10:03:01 +0200 (CEST)
From: =?iso-8859-1?q?Didier=20Arenzana?= <darenzana@yahoo.fr>
To: Shaun Colley <shaunige@yahoo.co.uk>, bugtraq@securityfocus.com
In-Reply-To: <20040406190415.85818.qmail@web25109.mail.ukl.yahoo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
--- Shaun Colley <shaunige@yahoo.co.uk> a écrit :
> Product: GNU Sharutils -
Hello,
I've juste read your advisory, and I'd like to advise your patch is
incomplete:
> [...]
> case 'o':
> - strcpy (output_base_name, optarg);
> + strncpy (output_base_name, optarg,
> sizeof(output_base_name));
You must add
output_base_name[sizeof(output_base_name)]='\0' ;
here, otherwize your string will not be null-termminated when optarg is too
long.
Regards,
Didier.
Yahoo! Mail : votre e-mail personnel et gratuit qui vous suit partout !
Créez votre Yahoo! Mail sur http://fr.benefits.yahoo.com/
Dialoguez en direct avec vos amis grâce à Yahoo! Messenger !Téléchargez Yahoo! Messenger sur http://fr.messenger.yahoo.com
